Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add csv and nkf to gem's dependency #1911

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

fabon-f
Copy link
Contributor

@fabon-f fabon-f commented May 29, 2024

Re:VIEWをRuby 3.3.1で実行すると、以下のようなwarningが発生します。(csvとnkfは3.4以降default gemでなくなる予定)

本PRはgemの依存先にcsvとnkfを追加するもので、それによってwarningの発生を抑止し、(おそらく今年の年末にリリースされる)3.4以降のRubyのアップデートに対応できるようにします。

$HOME/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/gems/review-5.9.0/lib/review/textutils.rb:9: warning: nkf was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add nkf to your Gemfile or gemspec. Also contact author of review-5.9.0 to add nkf into its gemspec.
$HOME/.rbenv/versions/3.3.1/lib/ruby/gems/3.3.0/gems/review-5.9.0/lib/review/builder.rb:19: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of review-5.9.0 to add csv into its gemspec.

参照: 3.3.0のリリースノートの"Standard library updates"節

kmuto added a commit that referenced this pull request May 29, 2024
@kmuto
Copy link
Owner

kmuto commented May 29, 2024

ありがとうございます! 3.4.0-preview1を試しに仕掛けてみて、失敗の再現およびいただいたPR内容で改善できることを確認しました。

@kmuto kmuto merged commit 2f993b3 into kmuto:master May 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants