Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LATEXBuilder: use \reviewunderline instead of \Underline #408

Merged
merged 5 commits into from
Feb 1, 2016

Conversation

takahashim
Copy link
Collaborator

fix #406

When jumoline.sty is loaded, \reviewunderline is redefined as \Underline
@kmuto
Copy link
Owner

kmuto commented Mar 24, 2015

手元では影響は1つくらいなのでマージして問題ないです。
スタイルをカスタムしてると影響出そうなので、Newsに掲載したほうがよさそうですね。

@takahashim
Copy link
Collaborator Author

一晩寝かせて考えてみましたが、このやり方だとjumoline.styが読み込まれてしまうと強制的にそれが使われてしまう感じですよね…。あんまりうれしくない気がしてきました。

@takahashim
Copy link
Collaborator Author

仕方がないので\reviewunderlineを作って、デフォルトは\Underlineにしてみました。
\underlineを使うには再定義していただく方向で。

kdmsnr added a commit that referenced this pull request Feb 1, 2016
LATEXBuilder: use \reviewunderline instead of \Underline
@kdmsnr kdmsnr merged commit c57ef28 into master Feb 1, 2016
@takahashim takahashim deleted the reviewunderline branch February 1, 2016 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@<u> のLaTeX表現
3 participants