Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add command //imgtable #499

Merged
merged 1 commit into from
Apr 14, 2016
Merged

add command //imgtable #499

merged 1 commit into from
Apr 14, 2016

Conversation

takahashim
Copy link
Collaborator

画像で作った表を埋め込むコマンドです。
相当前に作ったpatchなので要検証。

@kmuto
Copy link
Owner

kmuto commented Apr 2, 2016

機能としてはよさそうです。imageやindepimageのほうもそうなんですが、altの内容はキャプションでいいのか、というところで少し悩んでいます(今日の議題にもちょっと入れたい)。

@takahashim takahashim changed the title [WIP] add command //imgtable add command //imgtable Apr 3, 2016
@kmuto
Copy link
Owner

kmuto commented Apr 8, 2016

.rubocopのパッチの理由が謎ですが、masterに入ったらidgxmlbuilderのほうも調整してみます。

@takahashim
Copy link
Collaborator Author

.rubocopの方は1クラスの行数がエラーが出るようでした…そんなこと言われてもどうにもならないですが。

実際の画像ファイルで試せてないのであとでなんとかします。

@kmuto kmuto mentioned this pull request Apr 14, 2016
8 tasks
@takahashim
Copy link
Collaborator Author

実際のサンプルでもちゃんと動作するようなので取り込みます。

@takahashim takahashim merged commit 0424731 into kmuto:master Apr 14, 2016
@takahashim takahashim deleted the imgtable branch April 14, 2016 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants