Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not break argument lines #884

Merged
merged 1 commit into from
Dec 12, 2017
Merged

do not break argument lines #884

merged 1 commit into from
Dec 12, 2017

Conversation

takahashim
Copy link
Collaborator

pull requestに対するpull requestでアレですが、こんな感じでどうでしょうか。

  • linesは壊さない
  • メソッドは適宜分割したい
  • if修飾子やwhile修飾子は複雑な場合は使わない方が読みやすそう
  • lines[lines.size - 1]lines[-1]で良さそう

@kmuto
Copy link
Owner

kmuto commented Dec 12, 2017

ありがとうございます、助かります。挙動も問題なさそうなので、マージしちゃいますね。

@kmuto kmuto merged commit d665bbd into strip_p Dec 12, 2017
@kmuto kmuto deleted the fix-strip_p branch December 12, 2017 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants