Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fedibird_capabilitiesからprofile_searchを削除 #322

Closed
kmycode opened this issue Dec 1, 2023 · 0 comments · Fixed by #387
Closed

fedibird_capabilitiesからprofile_searchを削除 #322

kmycode opened this issue Dec 1, 2023 · 0 comments · Fixed by #387
Labels
cost-low specchange
Milestone
kb10.0

Comments

@kmycode
Copy link
Owner

kmycode commented Dec 1, 2023 •
edited
Loading

挙動を変更してほしい機能や動作

/api/v1/instanceのfedibird_capabilities

現在の挙動

全文検索を有効にしていないサーバーにおいて、profile_searchが含まれる

変更してほしい新しい挙動

profile_searchを削除し、full_text_searchに置き換える

必要性

そもそも全文検索が利用できるかの見分けのためのものではない（当時はなんとなくで書き足していた部分）
https://blog.noellabo.jp/entry/profile_search_features_specification

LTSと最新版で対応内容が異なるため、それぞれに対応
破壊的変更となるためLTSでは対応せず、メジャーアップデートのみで対応を行う
@kmycode kmycode modified the milestones: kb5.x LTS, kb10.0 Dec 1, 2023
kmycode added a commit that referenced this issue Dec 26, 2023
@kmycode
Change: #322 fedibird_capabilitiesからprofile_searchを削除
769905e
@kmycode kmycode mentioned this issue Dec 26, 2023
Merged
kmycode added a commit that referenced this issue Dec 26, 2023
@kmycode
Change: #322 fedibird_capabilitiesからprofile_searchを削除 (#387)
fb6e125 
* Change: #322 `fedibird_capabilities`から`profile_search`を削除

* v1にも追加
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cost-low specchange
Projects
None yet
Milestone
kb10.0
Development

Successfully merging a pull request may close this issue.

Change: #322 fedibird_capabilitiesからprofile_searchを削除 kmycode/mastodon
1 participant
@kmycode