Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update file watch to trigger callback after symbolic link changes #326

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jondavidnd1
Copy link
Contributor

This fixes issue 323. The changes are based mostly on similar code found in the viper codebase.

@jondavidnd1
Copy link
Contributor Author

Sorry, I didn't want to stack too many commits so I closed the old PR and started from scratch. Apologies for not originally seeing the watch tests. I have added an additional watch test to mimic what kubernetes does and validated that the test is successful on my branch and failed without my changes (I did have to add a waitTimeout function otherwise the tests just hung waiting for the watch trigger).

@jondavidnd1
Copy link
Contributor Author

@knadh not urgent, but would appreciate a review when you have a chance. Thanks.

@knadh knadh merged commit cec6d28 into knadh:master Oct 2, 2024
4 checks passed
@knadh
Copy link
Owner

knadh commented Oct 2, 2024

Released as providers/file/v1.1.1. Thanks for the PR!

@jondavidnd1
Copy link
Contributor Author

Released as providers/file/v1.1.1. Thanks for the PR!

You're welcome, and thanks for the great library.

@jondavidnd1
Copy link
Contributor Author

Released as providers/file/v1.1.1. Thanks for the PR!

@knadh , perhaps I misunderstood, the changes are now on master but they don't appear to be in that tag (providers/file/v1.1.1 created last week).

@knadh
Copy link
Owner

knadh commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Watch not triggering with Kubernetes ConfigMap changes
2 participants