This repository was archived by the owner on Jun 14, 2019. It is now read-only.
fix(protractor-$timeout): use $interval service for reply timeouts so pr... #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...otractor tests can continue
When using protractor for e2e testing it waits for all pending timeouts to complete and only then will it move on to the next test. For this reason it is important to cancel any timeouts which have been set when they are no longer needed. Currently my tests wait for 10 seconds even though they have received the correct response from the event bus.
This change replaces the $timeout service with the $interval service as the $interval service does not prevent protractor from continuing (angular/angular.js#2402)