Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workflow to enable test runs for new contributors #175

Closed
wants to merge 1 commit into from
Closed

add workflow to enable test runs for new contributors #175

wants to merge 1 commit into from

Conversation

pseudorandoom
Copy link
Contributor

Changes

  • Trigger workflow approval when ok-to-test label is added to a PR

/kind ehancement

Fixes #knative/test-infra/issues/3057

Release Note

Knobots to be updated to account for the new workflow and copy it to the necessary repos

Docs

@knative-prow-robot
Copy link

@shinigambit: The label(s) kind/ehancement cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Trigger workflow approval when ok-to-test label is added to a PR

/kind ehancement

Fixes #knative/test-infra/issues/3057

Release Note

Knobots to be updated to account for the new workflow and copy it to the necessary repos

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shinigambit
To complete the pull request process, please assign cardil after the PR has been reviewed.
You can assign the PR to them by writing /assign @cardil in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 10, 2022
@dprotaso
Copy link
Contributor

dprotaso commented Feb 10, 2022 •
edited
Loading

/hold going to comment on the issue

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 10, 2022
@pseudorandoom pseudorandoom marked this pull request as draft February 10, 2022 16:09
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 10, 2022
@dprotaso
Copy link
Contributor

Going to close this as productivity agreed with a different approach

knative/test-infra#3057 (comment)

@dprotaso dprotaso closed this Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pseudorandoom @knative-prow-robot @dprotaso