Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for custom metrics #26

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jul 11, 2024

Changes

  • Follows the approach in here.
  • Brings in some dependencies from Serving. TODO there is to make some test methods public at the Serving side so code can be removed later on.

Fixes #12

Release Note

Custom metrics are now tested e2e.  

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
Copy link

knative-prow bot commented Jul 11, 2024

@skonto: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • TBD

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2024
@knative-prow knative-prow bot requested review from cardil and izabelacg July 11, 2024 16:06
@skonto skonto removed request for cardil and izabelacg July 11, 2024 16:18
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.63%. Comparing base (5c704df) to head (2f0dcc5).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   53.60%   63.63%   +10.03%     
===========================================
  Files           5        4        -1     
  Lines         222      187       -35     
===========================================
  Hits          119      119               
+ Misses         95       60       -35     
  Partials        8        8               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto skonto force-pushed the add_custom_metrics_test branch from ceb464e to 2f0dcc5 Compare July 12, 2024 08:53
@skonto skonto changed the title [wip] [TEST] Add custom metrics test Add e2e test for custom metrics Jul 12, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 12, 2024
@skonto skonto requested a review from ReToCode July 12, 2024 09:00
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024
Copy link

knative-prow bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit e650989 into knative-extensions:main Jul 15, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integrations tests
2 participants