This repository has been archived by the owner on May 2, 2023. It is now read-only.
Update calico install in e2e test #216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
approved
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
=======================================
Coverage 67.35% 67.35%
=======================================
Files 5 5
Lines 193 193
=======================================
Hits 130 130
Misses 44 44
Partials 19 19 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
|
@jwcesign can you take a look at the failing cri-o tests? |
|
sure |
|
Hi, @psschwei , so it doesn't need to be fixed? |
|
Yeah, given #217 we can ignore these |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul S. Schweigert paul@paulschweigert.com