Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default for KafkaActivationLagThreshold from 0 to 1 #340

Closed
wants to merge 2 commits into from
Closed

Change default for KafkaActivationLagThreshold from 0 to 1 #340

wants to merge 2 commits into from

Conversation

aavarghese
Copy link
Contributor

Signed-off-by: aavarghese avarghese@us.ibm.com

Changes

  • 🐛 Change default for KafkaActivationLagThreshold from 0 to 1

/kind bug

Fixes #339

Release Note

Change default for KafkaActivationLagThreshold from 0 to 1

Docs

@aavarghese
Change default for KafkaActivationLagThreshold from 0 to 1
31f5d95 
Signed-off-by: aavarghese <avarghese@us.ibm.com>
@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2022
@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2023
@pierDipi pierDipi requested a review from zroubalik February 20, 2023 07:10
@pierDipi
Copy link
Member

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 20, 2023
@knative-prow
Copy link

knative-prow bot commented Apr 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aavarghese
Once this PR has been reviewed and has the lgtm label, please assign lionelvillard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@github-actions github-actions bot closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default value for KafkaActivationLagThreshold throws error
2 participants
@aavarghese @pierDipi