Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "connector.event" prefix in favor of "eventing" #38

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

christophd
Copy link
Contributor

Changes

  • Remove the connector.event prefix for default event types in favor of using eventing
  • Fix README regarding archetype names

For instance uses the event type dev.knative.eventing.aws-ddb-streams instead of dev.knative.connector.event.aws-ddb-streams for events produced by the IntegrationSource.

/kind enhancement

Relates to #36

Release Note


Docs


Copy link

knative-prow bot commented Nov 28, 2024

@christophd: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Remove the connector.event prefix for default event types in favor of using eventing
  • Fix README regarding archetype names

For instance uses the event type dev.knative.eventing.aws-ddb-streams instead of dev.knative.connector.event.aws-ddb-streams for events produced by the IntegrationSource.

/kind enhancement

Relates to #36

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

knative-prow bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christophd, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d7ce98e into knative-extensions:main Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants