-
Notifications
You must be signed in to change notification settings - Fork 117
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Probing is done using the knative/networking data-plane contract (already implemented in Eventing through knative/pkg). ref issue knative/eventing#3911 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
- Loading branch information
Showing
5 changed files
with
160 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 35 additions & 0 deletions
35
...c/main/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/ProbeRequestUtil.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /* | ||
| * Copyright © 2018 Knative Authors (knative-dev@googlegroups.com) | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package dev.knative.eventing.kafka.broker.receiver.impl.handler; | ||
|
|
||
| import io.vertx.core.http.HttpMethod; | ||
| import io.vertx.core.http.HttpServerRequest; | ||
|
|
||
| public class ProbeRequestUtil { | ||
|
|
||
| public static final String PROBE_HEADER_NAME = "K-Network-Probe"; | ||
|
|
||
| public static final String PROBE_HEADER_VALUE = "probe"; | ||
|
|
||
| public static final String PROBE_HASH_HEADER_NAME = "K-Network-Hash"; | ||
|
|
||
| public static boolean isProbeRequest(final HttpServerRequest request) { | ||
| final var headers = request.headers(); | ||
| return HttpMethod.GET.equals(request.method()) && | ||
| headers.contains(PROBE_HEADER_NAME) && | ||
| headers.get(PROBE_HEADER_NAME).equals(PROBE_HEADER_VALUE); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
...st/java/dev/knative/eventing/kafka/broker/receiver/impl/handler/ProbeRequestUtilTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* | ||
| * Copyright © 2018 Knative Authors (knative-dev@googlegroups.com) | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package dev.knative.eventing.kafka.broker.receiver.impl.handler; | ||
|
|
||
| import io.vertx.core.http.HttpMethod; | ||
| import io.vertx.core.http.HttpServerRequest; | ||
| import io.vertx.core.http.impl.headers.HeadersMultiMap; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static dev.knative.eventing.kafka.broker.receiver.impl.handler.ProbeRequestUtil.PROBE_HEADER_NAME; | ||
| import static dev.knative.eventing.kafka.broker.receiver.impl.handler.ProbeRequestUtil.PROBE_HEADER_VALUE; | ||
| import static dev.knative.eventing.kafka.broker.receiver.impl.handler.ProbeRequestUtil.isProbeRequest; | ||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class ProbeRequestUtilTest { | ||
|
|
||
| @Test | ||
| public void shouldBeProbeRequest() { | ||
| final var headers = new HeadersMultiMap() | ||
| .add(PROBE_HEADER_NAME, PROBE_HEADER_VALUE); | ||
| final var request = mock(HttpServerRequest.class); | ||
| when(request.method()).thenReturn(HttpMethod.GET); | ||
| when(request.headers()).thenReturn(headers); | ||
|
|
||
| assertThat(isProbeRequest(request)).isTrue(); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldNotBeProbeRequestWrongValue() { | ||
| final var headers = new HeadersMultiMap() | ||
| .add(PROBE_HEADER_NAME, PROBE_HEADER_VALUE + "a"); | ||
| final var request = mock(HttpServerRequest.class); | ||
| when(request.method()).thenReturn(HttpMethod.GET); | ||
| when(request.headers()).thenReturn(headers); | ||
|
|
||
| assertThat(isProbeRequest(request)).isFalse(); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldNotBeProbeRequestNoProbeHeader() { | ||
| final var headers = new HeadersMultiMap(); | ||
| final var request = mock(HttpServerRequest.class); | ||
| when(request.method()).thenReturn(HttpMethod.GET); | ||
| when(request.headers()).thenReturn(headers); | ||
|
|
||
| assertThat(isProbeRequest(request)).isFalse(); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldNotBeProbeRequestWrongMethod() { | ||
| final var headers = new HeadersMultiMap(); | ||
| final var request = mock(HttpServerRequest.class); | ||
| when(request.method()).thenReturn(HttpMethod.POST); | ||
| when(request.headers()).thenReturn(headers); | ||
|
|
||
| assertThat(isProbeRequest(request)).isFalse(); | ||
| } | ||
| } |