-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-0.25] Add namespace to referenced addressable before resolving destination #1262
[release-0.25] Add namespace to referenced addressable before resolving destination #1262
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
The resolver uses `ref.namespace` to lookup the destination addressable. `ref.namespace` for the `deadLetterSink` is not defaulted by the webhook like for `trigger.subscriber.ref`, so we might receive a destination with an empty string for `deadLetterSink.ref.namespace` which leads to not finding the referenced addressable service. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
78c1b1b
to
a1037c5
Compare
@googlebot I consent. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## release-0.25 #1262 +/- ##
===============================================
Coverage ? 75.82%
Complexity ? 460
===============================================
Files ? 87
Lines ? 3036
Branches ? 136
===============================================
Hits ? 2302
Misses ? 568
Partials ? 166
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This is an automated cherry-pick of #1254