Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable KafkaSource auth support #1403

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Enable KafkaSource auth support #1403

merged 1 commit into from
Nov 3, 2021

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Nov 3, 2021

Part of #312

Proposed Changes

  • Enable KafkaSource auth support

Release Note

None

Docs

None

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 3, 2021
@knative-prow-robot knative-prow-robot added area/control-plane size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 3, 2021
@pierDipi pierDipi requested review from matzew, aliok and devguyio November 3, 2021 09:33
@pierDipi pierDipi force-pushed the KNATIVE-312_Enable-Auth-support branch from 553ebc2 to 4ee3c26 Compare November 3, 2021 09:33
@codecov
Copy link

codecov bot commented Nov 3, 2021 •
edited
Loading

Codecov Report

Merging #1403 (4b005c3) into main (1b47375) will increase coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1403      +/-   ##
============================================
+ Coverage     76.36%   76.37%   +0.01%     
+ Complexity      584      583       -1     
============================================
  Files            98       98              
  Lines          3626     3632       +6     
  Branches        165      166       +1     
============================================
+ Hits           2769     2774       +5     
- Misses          645      646       +1     
  Partials        212      212
Flag Coverage Δ
java-unittests 82.18% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntrol-plane/pkg/reconciler/source/auth_provider.go 81.81% <87.50%> (+31.81%) ⬆️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 86.20% <0.00%> (-6.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b47375...4b005c3. Read the comment docs.

matzew
matzew reviewed Nov 3, 2021
View reviewed changes
control-plane/pkg/reconciler/source/auth_provider.go Outdated
@@ -28,23 +28,20 @@ func (ks *SecretLocator) SecretName() (string, bool) {
if !hasAuthConfig(ks.KafkaSource) {
return "", false
}
return getName(ks.KafkaSource), hasAuthConfig(ks.KafkaSource)
// KafkaSource uses a special secret provider, so there is no need to return a name here.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

special, as in? mind linking to details?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if the new commit solves your comment

@pierDipi
Enable KafkaSource auth support
4b005c3 
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@pierDipi pierDipi force-pushed the KNATIVE-312_Enable-Auth-support branch from 4ee3c26 to 4b005c3 Compare November 3, 2021 10:05
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/source/auth_provider.go 50.0% 60.0% 10.0

@pierDipi pierDipi requested a review from matzew November 3, 2021 11:08
matzew
matzew approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit e54534f into knative-extensions:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@devguyio devguyio Awaiting requested review from devguyio

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pierDipi @knative-metrics-robot @knative-prow-robot @matzew