Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize topic name builder function and usages #1416

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

aliok
Copy link
Member

@aliok aliok commented Nov 5, 2021

Fixes #

Proposed Changes

  • Organize topic name builder function and usages
  • Move the channel specific one to kafka package. Needed for future testing.
  • Hardcode topic name format for KafkaSink testing

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 5, 2021
@knative-prow-robot knative-prow-robot added area/control-plane area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/kafka/topic.go 100.0% 97.5% -2.5

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1416 (9c1642e) into main (c108f41) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1416      +/-   ##
============================================
- Coverage     76.24%   76.22%   -0.03%     
  Complexity      584      584              
============================================
  Files            98       98              
  Lines          3658     3659       +1     
  Branches        166      166              
============================================
  Hits           2789     2789              
- Misses          653      654       +1     
  Partials        216      216              
Flag Coverage Δ
java-unittests 82.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/reconciler/kafka/topic.go 97.67% <0.00%> (-2.33%) ⬇️
control-plane/pkg/reconciler/broker/broker.go 70.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c108f41...9c1642e. Read the comment docs.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aliok
Copy link
Member Author

aliok commented Nov 5, 2021

/test pull-knative-sandbox-eventing-kafka-broker-integration-tests

@knative-prow-robot knative-prow-robot merged commit 141ddb8 into knative-extensions:main Nov 5, 2021
@aliok aliok deleted the kafka-topic-func branch November 8, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants