-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize topic name builder function and usages #1416
Organize topic name builder function and usages #1416
Conversation
The following is the coverage report on the affected files.
|
Codecov Report
@@ Coverage Diff @@
## main #1416 +/- ##
============================================
- Coverage 76.24% 76.22% -0.03%
Complexity 584 584
============================================
Files 98 98
Lines 3658 3659 +1
Branches 166 166
============================================
Hits 2789 2789
- Misses 653 654 +1
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests |
Fixes #
Proposed Changes
kafka
package. Needed for future testing.Release Note
Docs