Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Kafka channel reconciler tests #1447

Conversation

aliok
Copy link
Member

@aliok aliok commented Nov 9, 2021

Fixes #

Proposed Changes

  • Pushing for early feedback
  • Check individual commits

Release Note


Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 9, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 9, 2021
@knative-prow-robot knative-prow-robot added area/control-plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2021
@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1447 (5b1cff5) into main (f388998) will increase coverage by 1.94%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1447      +/-   ##
============================================
+ Coverage     71.51%   73.46%   +1.94%     
+ Complexity      585      574      -11     
============================================
  Files           100      100              
  Lines          3964     3942      -22     
  Branches        166      160       -6     
============================================
+ Hits           2835     2896      +61     
+ Misses          912      808     -104     
- Partials        217      238      +21     
Flag Coverage Δ
java-unittests 82.27% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/reconciler/channel/channel.go 30.07% <0.00%> (+30.07%) ⬆️
control-plane/pkg/reconciler/channel/controller.go 86.00% <100.00%> (+0.28%) ⬆️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 86.20% <0.00%> (-6.90%) ⬇️
...a/broker/dispatcher/impl/RecordDispatcherImpl.java 81.92% <0.00%> (-0.64%) ⬇️
...spatcher/impl/consumer/UnorderedOffsetManager.java
...dispatcher/impl/consumer/OrderedOffsetManager.java
...broker/dispatcher/impl/consumer/OffsetManager.java 100.00% <0.00%> (ø)
control-plane/pkg/prober/cache.go 100.00% <0.00%> (ø)
...r/dispatcher/main/ConsumerVerticleFactoryImpl.java 88.07% <0.00%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f388998...5b1cff5. Read the comment docs.

Comment on lines 117 to 119
// TODO: tests with and without subscriptions
// TODO: tests for things from config-kafka (partition count, etc)
// TODO: are we setting a InitialOffsetsCommitted status?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR contains a single test, will add more later

@aliok aliok changed the title [WIP] Initial Kafka channel reconciler tests Initial Kafka channel reconciler tests Nov 10, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2021
@aliok
Copy link
Member Author

aliok commented Nov 10, 2021

@pierDipi
I removed the WIP status. I want to merge this PR and add more tests later (I will NOT do a separate PR for each test case, don't worry 😄 ).

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/channel/channel.go 0.0% 39.8% 39.8

@knative-prow-robot
Copy link
Contributor

@aliok: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-sandbox-eventing-kafka-broker-go-coverage 5b1cff5 link false /test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit fb707d4 into knative-extensions:main Nov 10, 2021
@aliok aliok deleted the 2021-11-09-kafka-ch-reconciler-tests branch November 10, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants