-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Kafka channel reconciler tests #1447
Initial Kafka channel reconciler tests #1447
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1447 +/- ##
============================================
+ Coverage 71.51% 73.46% +1.94%
+ Complexity 585 574 -11
============================================
Files 100 100
Lines 3964 3942 -22
Branches 166 160 -6
============================================
+ Hits 2835 2896 +61
+ Misses 912 808 -104
- Partials 217 238 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
// TODO: tests with and without subscriptions | ||
// TODO: tests for things from config-kafka (partition count, etc) | ||
// TODO: are we setting a InitialOffsetsCommitted status? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR contains a single test, will add more later
@pierDipi |
The following is the coverage report on the affected files.
|
@aliok: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
Proposed Changes
Release Note
Docs