[release-1.0] Commit offsets at specified intervals #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
knative-prow-robot
added
the
cla: yes
knative-prow-robot
added
size/XL
Codecov Report
@@ Coverage Diff @@
## release-1.0 #1449 +/- ##
=================================================
- Coverage 76.57% 76.36% -0.21%
+ Complexity 584 574 -10
=================================================
Files 99 97 -2
Lines 3607 3542 -65
Branches 165 159 -6
=================================================
- Hits 2762 2705 -57
+ Misses 635 629 -6
+ Partials 210 208 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
matzew
added a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Nov 11, 2021
…ns#1449) * Commit offset at a specified interval Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Add reset logic to handle long large offsets Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Use final Co-authored-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Pierangelo Di Pilato <pdipilat@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1405