-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ConsumerGroup filter function based on owner refs #1615
Add a ConsumerGroup filter function based on owner refs #1615
Conversation
Every user-facing resource keeps track of the associated ConsumerGroup resources. This patch adds a generic filter function to be used by KafkaSource, Trigger, and KafkaChannel reconciler. Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
The following is the coverage report on the affected files.
|
@pierDipi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## main #1615 +/- ##
============================================
- Coverage 73.12% 72.44% -0.68%
Complexity 597 597
============================================
Files 118 120 +2
Lines 4375 4424 +49
Branches 171 171
============================================
+ Hits 3199 3205 +6
- Misses 911 954 +43
Partials 265 265
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aavarghese, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Every user-facing resource keeps track of the associated
ConsumerGroup resources.
This patch adds a generic filter function to be used by
KafkaSource, Trigger, and KafkaChannel reconciler.
Part of #1537
Proposed Changes
Release Note
Docs