Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ConsumerGroup filter function based on owner refs #1615

Conversation

pierDipi
Copy link
Member

Every user-facing resource keeps track of the associated
ConsumerGroup resources.

This patch adds a generic filter function to be used by
KafkaSource, Trigger, and KafkaChannel reconciler.

Part of #1537

Proposed Changes

  • Add a ConsumerGroup filter function

Release Note

None

Docs

None

Every user-facing resource keeps track of the associated
ConsumerGroup resources.

This patch adds a generic filter function to be used by
KafkaSource, Trigger, and KafkaChannel reconciler.

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane labels Dec 15, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/consumergroup/filter.go Do not exist 100.0%
control-plane/pkg/reconciler/trigger/v2/controllerv2.go 34.1% 38.9% 4.7

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Dec 15, 2021

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-sandbox-eventing-kafka-broker-go-coverage 697161b link false /test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #1615 (697161b) into main (2e8d011) will decrease coverage by 0.67%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1615      +/-   ##
============================================
- Coverage     73.12%   72.44%   -0.68%     
  Complexity      597      597              
============================================
  Files           118      120       +2     
  Lines          4375     4424      +49     
  Branches        171      171              
============================================
+ Hits           3199     3205       +6     
- Misses          911      954      +43     
  Partials        265      265              
Flag Coverage Δ
java-unittests 81.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntrol-plane/pkg/reconciler/consumergroup/filter.go 100.00% <100.00%> (ø)
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go 57.69% <100.00%> (+7.69%) ⬆️
control-plane/pkg/prober/prober.go 60.00% <0.00%> (-15.00%) ⬇️
control-plane/pkg/prober/cache.go 95.23% <0.00%> (-4.77%) ⬇️
...lane/pkg/reconciler/consumergroup/consumergroup.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e8d011...697161b. Read the comment docs.

Copy link
Contributor

@aavarghese aavarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 37092a9 into knative-extensions:main Dec 15, 2021
@pierDipi pierDipi deleted the SRVKE-1060_ConsumerGroup-filter-function branch December 15, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants