KafkaChannel Reconciler for ConsumerGroup scaling #1618

aavarghese · 2021-12-15T21:45:57Z

Signed-off-by: aavarghese avarghese@us.ibm.com

Part of #1537 (channelv2_test.go coming soon)

Proposed Changes

Adding new KafkaChannel reconciler to create ConsumerGroup resources

Release Note

Docs

codecov · 2021-12-15T21:49:48Z

Codecov Report

Merging #1618 (f59cd99) into main (8704980) will decrease coverage by 3.07%.
The diff coverage is 9.91%.

@@             Coverage Diff              @@
##               main    #1618      +/-   ##
============================================
- Coverage     66.45%   63.37%   -3.08%     
  Complexity      629      629              
============================================
  Files           138      140       +2     
  Lines          6129     6482     +353     
  Branches        179      179              
============================================
+ Hits           4073     4108      +35     
- Misses         1725     2043     +318     
  Partials        331      331

Flag	Coverage Δ
java-unittests	`82.08% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...afka/eventing/v1alpha1/consumer_group_lifecycle.go	`0.00% <ø> (ø)`
...ntrol-plane/pkg/reconciler/channel/v2/channelv2.go	`0.00% <0.00%> (ø)`
...fka/eventing/v1alpha1/consumer_group_validation.go	`100.00% <100.00%> (ø)`
...ol-plane/pkg/reconciler/channel/v2/controllerv2.go	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8704980...f59cd99. Read the comment docs.

aavarghese · 2021-12-17T15:31:12Z

/cc @pierDipi

control-plane/pkg/reconciler/channel/v2/channelv2.go

aavarghese · 2022-01-14T06:57:23Z

@pierDipi if you have time for another review please? :)

control-plane/pkg/reconciler/channel/v2/channelv2.go

pierDipi

Thanks!

Some minor comments

control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_validation.go

control-plane/pkg/reconciler/channel/v2/channelv2.go

Signed-off-by: aavarghese <avarghese@us.ibm.com>

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Signed-off-by: aavarghese <avarghese@us.ibm.com>

pierDipi

/lgtm
/approve

We can address the nit in another PR, thanks!

control-plane/pkg/reconciler/channel/v2/channelv2.go

knative-prow-robot · 2022-02-17T17:40:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi · 2022-02-17T17:41:26Z

/retest-required

aavarghese · 2022-02-17T21:30:51Z

/retest

knative-metrics-robot · 2022-02-17T21:34:35Z

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
control-plane/pkg/reconciler/channel/v2/channelv2.go	Do not exist	0.0%
control-plane/pkg/reconciler/channel/v2/controllerv2.go	Do not exist	100.0%

knative-prow-robot · 2022-02-17T21:34:39Z

@aavarghese: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-tls	`e371d41`	link	true	`/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-tls`
pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-tls	`e371d41`	link	true	`/test pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-tls`
pull-knative-sandbox-eventing-kafka-broker-go-coverage	`f59cd99`	link	false	`/test pull-knative-sandbox-eventing-kafka-broker-go-coverage`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

aavarghese · 2022-02-17T21:50:47Z

/test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests

knative-prow-robot · 2022-02-17T21:51:01Z

@aavarghese: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-knative-sandbox-eventing-kafka-broker-build-tests
/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-sasl-plain
/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-sasl-ssl
/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-ssl
/test pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-sasl-plain
/test pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-sasl-ssl
/test pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-ssl
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests
/test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests
/test pull-knative-sandbox-eventing-kafka-broker-unit-tests
/test pull-knative-sandbox-eventing-kafka-broker-upgrade-tests

The following commands are available to trigger optional jobs:

/test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-tls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aavarghese · 2022-02-17T21:54:46Z

/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-tls

knative-prow-robot · 2022-02-17T21:54:47Z

@aavarghese: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-knative-sandbox-eventing-kafka-broker-build-tests
/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-sasl-plain
/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-sasl-ssl
/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-ssl
/test pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-sasl-plain
/test pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-sasl-ssl
/test pull-knative-sandbox-eventing-kafka-broker-channel-reconciler-tests-ssl
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests
/test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests
/test pull-knative-sandbox-eventing-kafka-broker-unit-tests
/test pull-knative-sandbox-eventing-kafka-broker-upgrade-tests

The following commands are available to trigger optional jobs:

/test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Use /test all to run all jobs.

In response to this:

/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-tls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

knative-prow-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/control-plane labels Dec 15, 2021

aavarghese changed the title ~~[WIP] KafkaChannel Reconciler for ConsumerGroup scaling~~ KafkaChannel Reconciler for ConsumerGroup scaling Dec 17, 2021

knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2021

aavarghese force-pushed the consumer-scheduling-scaling-channel branch from afec462 to c560315 Compare December 17, 2021 15:22

knative-prow-robot requested a review from pierDipi December 17, 2021 15:31

pierDipi reviewed Jan 4, 2022

View reviewed changes

control-plane/pkg/reconciler/channel/v2/channelv2.go Outdated Show resolved Hide resolved

pierDipi reviewed Jan 4, 2022

View reviewed changes

control-plane/pkg/reconciler/channel/v2/channelv2.go Show resolved Hide resolved

aavarghese force-pushed the consumer-scheduling-scaling-channel branch 5 times, most recently from a82faba to 884711d Compare January 7, 2022 23:02

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2022

aavarghese force-pushed the consumer-scheduling-scaling-channel branch from 884711d to 2f36d2a Compare January 11, 2022 06:29

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2022

aavarghese force-pushed the consumer-scheduling-scaling-channel branch 2 times, most recently from c68e4fb to ae400b8 Compare January 11, 2022 18:13

aavarghese requested a review from pierDipi January 11, 2022 18:13

aavarghese force-pushed the consumer-scheduling-scaling-channel branch from ae400b8 to 3625830 Compare January 13, 2022 14:11

pierDipi reviewed Jan 14, 2022

View reviewed changes

control-plane/pkg/reconciler/channel/v2/channelv2.go Show resolved Hide resolved

knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2022

aavarghese force-pushed the consumer-scheduling-scaling-channel branch from 17a77ce to 42aca06 Compare January 14, 2022 18:51

pierDipi reviewed Jan 17, 2022

View reviewed changes

control-plane/pkg/reconciler/channel/v2/channelv2.go Outdated Show resolved Hide resolved

control-plane/pkg/reconciler/channel/v2/channelv2.go Outdated Show resolved Hide resolved

aavarghese mentioned this pull request Jan 27, 2022

[WIP] KafkaChannel reconciler tests for ConsumerGroup scaling #1817

Closed

pierDipi reviewed Feb 17, 2022

View reviewed changes

knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 17, 2022

aavarghese requested a review from pierDipi February 17, 2022 15:31

aavarghese added 4 commits February 17, 2022 10:55

KafkaChannel reconciler changes to create consumer group

711a14d

Signed-off-by: aavarghese <avarghese@us.ibm.com>

Review updates

225c288

Signed-off-by: aavarghese <avarghese@us.ibm.com>

Adding missing reconciler logic

6969be2

Signed-off-by: aavarghese <avarghese@us.ibm.com>

Review update for consumer group leak

ccc1206

Signed-off-by: aavarghese <avarghese@us.ibm.com>

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2022

aavarghese and others added 5 commits February 17, 2022 10:56

Review updates

ef80487

Signed-off-by: aavarghese <avarghese@us.ibm.com>

New CG label

4604a8f

Signed-off-by: aavarghese <avarghese@us.ibm.com>

Review updates

75d99e5

Signed-off-by: aavarghese <avarghese@us.ibm.com>

Update channelv2 reconciler for probe status change

c149d61

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>

Review updates

f59cd99

Signed-off-by: aavarghese <avarghese@us.ibm.com>

aavarghese force-pushed the consumer-scheduling-scaling-channel branch from 392752a to f59cd99 Compare February 17, 2022 15:57

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2022

pierDipi approved these changes Feb 17, 2022

View reviewed changes

control-plane/pkg/reconciler/channel/v2/channelv2.go Show resolved Hide resolved

knative-prow-robot assigned pierDipi Feb 17, 2022

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2022

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022

knative-prow-robot merged commit 148387a into knative-extensions:main Feb 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KafkaChannel Reconciler for ConsumerGroup scaling #1618

KafkaChannel Reconciler for ConsumerGroup scaling #1618

aavarghese commented Dec 15, 2021

codecov bot commented Dec 15, 2021 •

edited

Loading

aavarghese commented Dec 17, 2021

aavarghese commented Jan 14, 2022

pierDipi left a comment

pierDipi left a comment

knative-prow-robot commented Feb 17, 2022

pierDipi commented Feb 17, 2022

aavarghese commented Feb 17, 2022

knative-metrics-robot commented Feb 17, 2022

knative-prow-robot commented Feb 17, 2022 •

edited

Loading

aavarghese commented Feb 17, 2022

knative-prow-robot commented Feb 17, 2022

aavarghese commented Feb 17, 2022

knative-prow-robot commented Feb 17, 2022

KafkaChannel Reconciler for ConsumerGroup scaling #1618

KafkaChannel Reconciler for ConsumerGroup scaling #1618

Conversation

aavarghese commented Dec 15, 2021

Proposed Changes

codecov bot commented Dec 15, 2021 • edited Loading

Codecov Report

aavarghese commented Dec 17, 2021

aavarghese commented Jan 14, 2022

pierDipi left a comment

Choose a reason for hiding this comment

pierDipi left a comment

Choose a reason for hiding this comment

knative-prow-robot commented Feb 17, 2022

pierDipi commented Feb 17, 2022

aavarghese commented Feb 17, 2022

knative-metrics-robot commented Feb 17, 2022

knative-prow-robot commented Feb 17, 2022 • edited Loading

aavarghese commented Feb 17, 2022

knative-prow-robot commented Feb 17, 2022

aavarghese commented Feb 17, 2022

knative-prow-robot commented Feb 17, 2022

codecov bot commented Dec 15, 2021 •

edited

Loading

knative-prow-robot commented Feb 17, 2022 •

edited

Loading