Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] using sharedmain.MainNamed for all controllers #1690

Merged
merged 2 commits into from
Jan 4, 2022
Merged

[release-1.1] using sharedmain.MainNamed for all controllers #1690

merged 2 commits into from
Jan 4, 2022

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #1613

matzew added 2 commits January 4, 2022 16:25
@matzew @knative-prow-robot
using sharedmain.MainNamed for all controllers
817f488 
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew @knative-prow-robot
avoid kafka prefix
c2a996e
@knative-prow-robot knative-prow-robot mentioned this pull request Jan 4, 2022
Merged
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/control-plane labels Jan 4, 2022
matzew
matzew approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@codecov
Copy link

codecov bot commented Jan 4, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@01240b7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.1    #1690   +/-   ##
==============================================
  Coverage               ?   73.09%           
  Complexity             ?      595           
==============================================
  Files                  ?      118           
  Lines                  ?     4379           
  Branches               ?      171           
==============================================
  Hits                   ?     3201           
  Misses                 ?      914           
  Partials               ?      264
Flag Coverage Δ
java-unittests 81.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01240b7...c2a996e. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 4, 2022
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2022
@knative-prow-robot knative-prow-robot merged commit ce179a1 into knative-extensions:release-1.1 Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knative-prow-robot @matzew