Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSource reconciler tests for ConsumerGroup scaling #1757

Conversation

aavarghese
Copy link
Contributor

@aavarghese aavarghese commented Jan 18, 2022

Signed-off-by: aavarghese avarghese@us.ibm.com

Part of #1537
Will be rebased on #1754 done

/cc @pierDipi

Proposed Changes

  • Adding new KafkaSource reconciler unit tests for consumer scheduling and scaling

Release Note


Docs

@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/control-plane labels Jan 18, 2022
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1757 (f5a85dc) into main (178b818) will increase coverage by 1.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1757      +/-   ##
============================================
+ Coverage     66.21%   67.23%   +1.01%     
  Complexity      614      614              
============================================
  Files           129      129              
  Lines          5293     5325      +32     
  Branches        177      177              
============================================
+ Hits           3505     3580      +75     
+ Misses         1503     1461      -42     
+ Partials        285      284       -1     
Flag Coverage Δ
java-unittests 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rol-plane/pkg/reconciler/source/v2/controllerv2.go 100.00% <100.00%> (ø)
control-plane/pkg/reconciler/source/v2/sourcev2.go 83.82% <100.00%> (+83.82%) ⬆️
control-plane/pkg/reconciler/channel/channel.go 61.88% <0.00%> (-2.97%) ⬇️
control-plane/pkg/reconciler/sink/kafka_sink.go 71.59% <0.00%> (+0.52%) ⬆️
control-plane/pkg/reconciler/broker/broker.go 67.74% <0.00%> (+0.59%) ⬆️
control-plane/pkg/receiver/address.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178b818...f5a85dc. Read the comment docs.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2022
@aavarghese aavarghese force-pushed the consumer-scheduling-scaling-sourcetest branch from 5f33b29 to 962095e Compare January 18, 2022 21:31
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2022
Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese aavarghese force-pushed the consumer-scheduling-scaling-sourcetest branch from 962095e to 3860836 Compare January 18, 2022 23:05
@aavarghese
Copy link
Contributor Author

/cc @pierDipi

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, left a comment.

Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese aavarghese requested a review from pierDipi January 21, 2022 12:10
@knative-prow-robot knative-prow-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2022
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/source/v2/sourcev2.go 0.0% 82.4% 82.4

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022
@pierDipi
Copy link
Member

/test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests

@knative-prow-robot knative-prow-robot merged commit 7f82fc0 into knative-extensions:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants