-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KafkaSource reconciler tests for ConsumerGroup scaling #1757
KafkaSource reconciler tests for ConsumerGroup scaling #1757
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1757 +/- ##
============================================
+ Coverage 66.21% 67.23% +1.01%
Complexity 614 614
============================================
Files 129 129
Lines 5293 5325 +32
Branches 177 177
============================================
+ Hits 3505 3580 +75
+ Misses 1503 1461 -42
+ Partials 285 284 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5f33b29
to
962095e
Compare
Signed-off-by: aavarghese <avarghese@us.ibm.com>
962095e
to
3860836
Compare
/cc @pierDipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, left a comment.
Signed-off-by: aavarghese <avarghese@us.ibm.com>
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aavarghese, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-sandbox-eventing-kafka-broker-reconciler-tests |
Signed-off-by: aavarghese avarghese@us.ibm.com
Part of #1537
Will be rebased on #1754done/cc @pierDipi
Proposed Changes
Release Note
Docs