Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission to set ConfigMap owner references to controller #2007

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Add permission to set ConfigMap owner references to controller #2007

merged 1 commit into from
Mar 16, 2022

Conversation

pierDipi
Copy link
Member

This is needed to be able to set the owner reference of the
ConfigMaps to their associated pods.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

@pierDipi
Add permission to set ConfigMap owner references to controller
cbe3fed 
This is needed to being able to set the owner reference of the
ConfigMaps to their associated pods.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow-robot knative-prow-robot added area/control-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2022
@pierDipi
Copy link
Member Author

/assign @aavarghese

@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #2007 (cbe3fed) into main (beea315) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2007      +/-   ##
============================================
+ Coverage     67.27%   67.31%   +0.04%     
- Complexity      639      642       +3     
============================================
  Files           141      141              
  Lines          6692     6692              
  Branches        186      186              
============================================
+ Hits           4502     4505       +3     
+ Misses         1816     1812       -4     
- Partials        374      375       +1
Flag Coverage Δ
java-unittests 82.04% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tcher/impl/consumer/UnorderedConsumerVerticle.java 91.30% <0.00%> (+4.34%) ⬆️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 93.75% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beea315...cbe3fed. Read the comment docs.

@pierDipi
Copy link
Member Author

/retest

aavarghese
aavarghese approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@aavarghese aavarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks.
/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit cc53b41 into knative-extensions:main Mar 16, 2022
@pierDipi pierDipi deleted the KNATIVE-1537_Set-CM-owner-ref-perms branch March 16, 2022 19:21
@pierDipi pierDipi restored the KNATIVE-1537_Set-CM-owner-ref-perms branch August 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aavarghese aavarghese aavarghese approved these changes

Assignees

@aavarghese aavarghese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @knative-prow-robot @aavarghese