Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer cleanup of unused field #2022

Conversation

aavarghese
Copy link
Contributor

Signed-off-by: aavarghese avarghese@us.ibm.com

Part of #1537

Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese
Copy link
Contributor Author

/cc @pierDipi

@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 18, 2022
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #2022 (2d80afb) into main (d525d4b) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #2022      +/-   ##
============================================
+ Coverage     67.26%   67.29%   +0.03%     
  Complexity      640      640              
============================================
  Files           141      141              
  Lines          6708     6715       +7     
  Branches        187      187              
============================================
+ Hits           4512     4519       +7     
  Misses         1820     1820              
  Partials        376      376              
Flag Coverage Δ
java-unittests 81.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/reconciler/consumer/consumer.go 50.00% <0.00%> (ø)
control-plane/pkg/reconciler/source/v2/sourcev2.go 89.88% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d525d4b...2d80afb. Read the comment docs.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Comment on lines -139 to +136
return nil, fmt.Errorf("failed to resolve subcriber: %w", err)
return nil, fmt.Errorf("failed to resolve subscriber: %w", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2022
@pierDipi
Copy link
Member

/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-ssl

@knative-prow-robot knative-prow-robot merged commit 4d93dad into knative-extensions:main Mar 18, 2022
@aslom aslom mentioned this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants