-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consumer cleanup of unused field #2022
Consumer cleanup of unused field #2022
Conversation
/cc @pierDipi |
Codecov Report
@@ Coverage Diff @@
## main #2022 +/- ##
============================================
+ Coverage 67.26% 67.29% +0.03%
Complexity 640 640
============================================
Files 141 141
Lines 6708 6715 +7
Branches 187 187
============================================
+ Hits 4512 4519 +7
Misses 1820 1820
Partials 376 376
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
return nil, fmt.Errorf("failed to resolve subcriber: %w", err) | ||
return nil, fmt.Errorf("failed to resolve subscriber: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aavarghese, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-knative-sandbox-eventing-kafka-broker-channel-integration-tests-ssl |
Signed-off-by: aavarghese avarghese@us.ibm.com
Part of #1537