Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more permissions to set Pod finalizers for controller #2027

Conversation

aavarghese
Copy link
Contributor

Error previously seen:

type: 'Warning' reason: 'InternalError' failed to bind resource to pod: failed to get or create data plane ConfigMap knative-eventing/kafka-source-dispatcher-2: configmaps \"kafka-source-dispatcher-2\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>","knative.dev/pod":"kafka-controller-bfcdc9d66-mfkrh"}

Previous changes in #2024 weren't sufficient for the pods to fully come up.

Signed-off-by: aavarghese avarghese@us.ibm.com

Part of #1537

Signed-off-by: aavarghese <avarghese@us.ibm.com>
@aavarghese
Copy link
Contributor Author

/cc @pierDipi

@knative-prow-robot knative-prow-robot added area/control-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2022
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #2027 (7873e95) into main (79570ef) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2027   +/-   ##
=========================================
  Coverage     67.27%   67.27%           
  Complexity      640      640           
=========================================
  Files           141      141           
  Lines          6722     6722           
  Branches        187      187           
=========================================
  Hits           4522     4522           
  Misses         1822     1822           
  Partials        378      378           
Flag Coverage Δ
java-unittests 81.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79570ef...7873e95. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2022
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022
@knative-prow-robot knative-prow-robot merged commit 4397d99 into knative-extensions:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants