-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ConfigMap knative-eventing/config-kafka-source-defaults #2082
Add ConfigMap knative-eventing/config-kafka-source-defaults #2082
Conversation
This ConfigMap is used by the KEDA integration. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
/cherry-pick release-v1.3 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-v1.2 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #2082 +/- ##
=============================================
- Coverage 82.61% 66.61% -16.01%
- Complexity 675 676 +1
=============================================
Files 72 141 +69
Lines 2289 9033 +6744
Branches 195 195
=============================================
+ Hits 1891 6017 +4126
- Misses 292 2622 +2330
- Partials 106 394 +288
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pierDipi: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.2 |
/cherry-pick release-1.3 |
@pierDipi: new pull request created: #2085 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi: new pull request created: #2086 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This ConfigMap is used by the KEDA integration.
Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com