Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConfigMap knative-eventing/config-kafka-source-defaults #2082

Conversation

pierDipi
Copy link
Member

This ConfigMap is used by the KEDA integration.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

This ConfigMap is used by the KEDA integration.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane labels Apr 12, 2022
@pierDipi
Copy link
Member Author

/cherry-pick release-v1.3

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

/cherry-pick release-v1.2

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi pierDipi requested a review from matzew April 12, 2022 10:24
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #2082 (46ce500) into main (9714d76) will decrease coverage by 16.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #2082       +/-   ##
=============================================
- Coverage     82.61%   66.61%   -16.01%     
- Complexity      675      676        +1     
=============================================
  Files            72      141       +69     
  Lines          2289     9033     +6744     
  Branches        195      195               
=============================================
+ Hits           1891     6017     +4126     
- Misses          292     2622     +2330     
- Partials        106      394      +288     
Flag Coverage Δ
java-unittests 82.69% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/core/config/egress.go 100.00% <0.00%> (ø)
...ol-plane/pkg/apis/eventing/v1/broker_validation.go 73.68% <0.00%> (ø)
control-plane/pkg/reconciler/channel/channel.go 70.98% <0.00%> (ø)
control-plane/pkg/reconciler/trigger/controller.go 82.72% <0.00%> (ø)
.../pkg/apis/eventing/v1alpha1/kafka_sink_defaults.go 100.00% <0.00%> (ø)
control-plane/pkg/reconciler/sink/auth_provider.go 100.00% <0.00%> (ø)
control-plane/pkg/contract/serde.go 100.00% <0.00%> (ø)
control-plane/pkg/kafka/consumer_group_lag.go 62.59% <0.00%> (ø)
control-plane/pkg/reconciler/channel/controller.go 88.88% <0.00%> (ø)
...ol-plane/pkg/reconciler/channel/v2/controllerv2.go 100.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9714d76...46ce500. Read the comment docs.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5e5ade7 into knative-extensions:main Apr 12, 2022
@knative-prow-robot
Copy link
Contributor

@pierDipi: cannot checkout release-v1.3: error checking out release-v1.3: exit status 1. output: error: pathspec 'release-v1.3' did not match any file(s) known to git

In response to this:

/cherry-pick release-v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@pierDipi: cannot checkout release-v1.2: error checking out release-v1.2: exit status 1. output: error: pathspec 'release-v1.2' did not match any file(s) known to git

In response to this:

/cherry-pick release-v1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

/cherry-pick release-1.2

@pierDipi
Copy link
Member Author

/cherry-pick release-1.3

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #2085

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #2086

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants