Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize offset in ConsumerGroup reconciler #2091

Conversation

pierDipi
Copy link
Member

When the offset strategy is set to latest, we need to initialize
the offset in Kafka for that particular consumer group.

Signed-off-by: Pierangelo Di Pilato pierdipi@redhat.com

Part of #1537

@knative-prow knative-prow bot added area/control-plane size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 13, 2022
@pierDipi pierDipi force-pushed the cp-08092de5cd47ba424dcfe10a8aa594eb0cf2578f-init-offset-cg branch from fd49370 to 0dfab6b Compare April 13, 2022 07:43
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #2091 (e8576a4) into main (5e5ade7) will decrease coverage by 16.13%.
The diff coverage is 69.69%.

@@              Coverage Diff              @@
##               main    #2091       +/-   ##
=============================================
- Coverage     82.69%   66.56%   -16.14%     
+ Complexity      676      675        -1     
=============================================
  Files            72      142       +70     
  Lines          2289     9130     +6841     
  Branches        195      195               
=============================================
+ Hits           1893     6077     +4184     
- Misses          291     2648     +2357     
- Partials        105      405      +300     
Flag Coverage Δ
java-unittests 82.61% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...afka/eventing/v1alpha1/consumer_group_lifecycle.go 0.00% <0.00%> (ø)
...nternals/kafka/eventing/v1alpha1/consumer_types.go 79.41% <ø> (ø)
...l-plane/pkg/reconciler/consumergroup/controller.go 57.82% <ø> (ø)
...lane/pkg/reconciler/consumergroup/consumergroup.go 76.52% <63.63%> (ø)
control-plane/pkg/reconciler/consumergroup/auth.go 76.47% <76.47%> (ø)
...rnals/kafka/eventing/v1alpha1/consumer_defaults.go 82.35% <100.00%> (ø)
control-plane/pkg/reconciler/consumer/consumer.go 51.27% <100.00%> (ø)
...a/broker/dispatcher/impl/RecordDispatcherImpl.java 89.88% <0.00%> (-1.13%) ⬇️
control-plane/pkg/reconciler/trigger/controller.go 82.72% <0.00%> (ø)
...kafka/eventing/v1alpha1/consumer_group_defaults.go 100.00% <0.00%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5ade7...e8576a4. Read the comment docs.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the cp-08092de5cd47ba424dcfe10a8aa594eb0cf2578f-init-offset-cg branch from 0dfab6b to e8576a4 Compare April 13, 2022 08:01
@pierDipi
Copy link
Member Author

/test unit-tests_eventing-kafka-broker_main

Copy link
Contributor

@aavarghese aavarghese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit b48f3db into knative-extensions:main Apr 13, 2022
aavarghese pushed a commit to aavarghese/eventing-kafka-broker that referenced this pull request Apr 26, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
steven0711dong pushed a commit to steven0711dong/eventing-kafka-broker that referenced this pull request Apr 29, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants