-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor fix for missing allowed key type #2247
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2247 +/- ##
============================================
+ Coverage 65.61% 65.62% +0.01%
- Complexity 697 701 +4
============================================
Files 140 140
Lines 9158 9164 +6
Branches 208 208
============================================
+ Hits 6009 6014 +5
- Misses 2748 2752 +4
+ Partials 401 398 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold actually, can't we just use https://github.com/knative-sandbox/eventing-kafka/blob/main/pkg/apis/sources/v1beta1/kafka_types.go#L103 |
Signed-off-by: aavarghese <avarghese@us.ibm.com>
Signed-off-by: aavarghese <avarghese@us.ibm.com>
/test unit-tests_eventing-kafka-broker_main |
@matzew yeah, we should. Made that change in a new commit. Thanks! |
/test integration-tests_eventing-kafka-broker_main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aavarghese, matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Signed-off-by: aavarghese avarghese@us.ibm.com
Related to #2244
Fixes a problem in #2219
Part of #1537