Workaround for cert-manager update spec issue #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm setting the fields to what cert-manager expects so that we don't run into this issue cert-manager/cert-manager#6408 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
/cherry-pick release-1.11 |
knative-prow
bot
added
the
size/S
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #3390 +/- ##
=========================================
Coverage 61.54% 61.54%
- Complexity 761 762 +1
=========================================
Files 181 181
Lines 12322 12322
Branches 265 265
=========================================
+ Hits 7583 7584 +1
Misses 4142 4142
+ Partials 597 596 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
knative-prow
bot
merged commit e7017ef
into
knative-extensions:main
16 of 18 checks passed
|
@pierDipi: failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Oct 12, 2023
I'm setting the fields to what cert-manager expects so that we don't run into this issue cert-manager/cert-manager#6408 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-ci bot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Oct 12, 2023
…e-extensions#3390) (#854) * Workaround for cert-manager update spec issue (knative-extensions#3390) I'm setting the fields to what cert-manager expects so that we don't run into this issue cert-manager/cert-manager#6408 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Run make generate-release Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Leo6Leo
pushed a commit
to Leo6Leo/eventing-kafka-broker
that referenced
this pull request
Nov 14, 2023
I'm setting the fields to what cert-manager expects so that we don't run into this issue cert-manager/cert-manager#6408 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
…#3287 (#3387) * E2E tests for broker: TLS key pair rotation (#3287) * progress save * add the new cert rotation test * Update the rekt test * Format the files * workspace save * maven * Clean up * Clean up * Format * Fix the rekt test CA cert issue on Source Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Format fix * Re-order the prerequisite * Enable the strict transportation mode in TLS rekt tests * Fix the reviewDog comment * Update test/e2e_new/broker_eventing_tls_test.go Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Fix the format of the shell script * Fix the format of the shell script * Update the Strict feature flag * Add the code to inject the feature flag to the context in the broker controller * Run go import * Fix the controller tests * Set the default value to all other feature flags when we are updating the transport-encryption feature flag --------- Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Run Dependency update * Upgrade Knative eventing to release-1.11 * Upgrade Knative eventing to release-1.11 * Upgrade Knative eventing to release-1.11 * Expose tls port for broker (#3305) * Expose the port for HTTPS broker Co-authored-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Change the format Signed-off-by: Leo HC Li <36619969+Leo6Leo@users.noreply.github.com> * Update 500-receiver.yaml Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> --------- Signed-off-by: Leo HC Li <36619969+Leo6Leo@users.noreply.github.com> Co-authored-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Change the name of the secretVolumePath (#3303) * Workaround for cert-manager update spec issue (#3390) I'm setting the fields to what cert-manager expects so that we don't run into this issue cert-manager/cert-manager#6408 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Cherry pick b30da88 * Update to the latest knative eventing V1.11.6 * Cherry pick the keypair rotation commit * Cherry pick 1ddc823 * Run update-codegen * Update the receiververticle import * Run update-codegen * Run spotless * Modify the CI test, it seems like prow is using the wrong config to run the tests * Modify the CI test, it seems like prow is using the wrong config to run the tests * Modify the CI test, it seems like prow is using the wrong config to run the tests * Install the knative TLS eventing component * Install the knative TLS eventing component * Update missed dependencies * Update codegen * Revert the dependency version to the latest --------- Signed-off-by: Leo HC Li <36619969+Leo6Leo@users.noreply.github.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> Co-authored-by: Calum Murray <cmurray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm setting the fields to what cert-manager expects so that we don't run into this issue cert-manager/cert-manager#6408