Add .spec.subscribers[].name field in KafkaChannel to align with eventing-core channel definition
#3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting-core channel definition
knative-prow
bot
added
size/XS
knative-prow
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3845 +/- ##
=============================================
- Coverage 73.90% 49.61% -24.30%
=============================================
Files 100 246 +146
Lines 3407 14786 +11379
Branches 288 0 -288
=============================================
+ Hits 2518 7336 +4818
- Misses 716 6699 +5983
- Partials 173 751 +578
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test reconciler-tests |
|
/test integration-tests |
knative-prow
bot
merged commit 027e753
into
knative-extensions:main
28 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In knative/eventing#7733 we added the
.spec.subscribers[].namefield for Channels. This PR adjusts the KafkaChannel to support this field too.This helps with tests issues from #3770