Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent generation only updates #3915

Merged
merged 3 commits into from
May 31, 2024

Refactor to simplify and remove reconciler level change detection

9b4d7e0
Select commit
Loading
Failed to load commit list.
Merged

Prevent generation only updates #3915

Refactor to simplify and remove reconciler level change detection
9b4d7e0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 31, 2024 in 0s

49.24% (-4.36%) compared to 97732b7

View this Pull Request on Codecov

49.24% (-4.36%) compared to 97732b7

Details

Codecov Report

Attention: Patch coverage is 44.70588% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 49.24%. Comparing base (97732b7) to head (9b4d7e0).
Report is 1 commits behind head on main.

Files Patch % Lines
control-plane/pkg/reconciler/trigger/trigger.go 16.66% 7 Missing and 3 partials ⚠️
control-plane/pkg/reconciler/channel/channel.go 60.00% 6 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/broker/broker.go 36.36% 5 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/sink/kafka_sink.go 30.00% 5 Missing and 2 partials ⚠️
...ntrol-plane/pkg/reconciler/channel/v2/channelv2.go 28.57% 4 Missing and 1 partial ⚠️
control-plane/pkg/reconciler/consumer/consumer.go 54.54% 3 Missing and 2 partials ⚠️
control-plane/pkg/reconciler/base/reconciler.go 62.50% 2 Missing and 1 partial ⚠️
control-plane/pkg/contract/extensions.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3915      +/-   ##
============================================
- Coverage     53.59%   49.24%   -4.36%     
============================================
  Files           344      247      -97     
  Lines         18346    14925    -3421     
  Branches        294        0     -294     
============================================
- Hits           9833     7350    -2483     
+ Misses         7575     6816     -759     
+ Partials        938      759     -179

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov