Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use v2 specific label to avoid matching previous deployment-based dispatchers #4104

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Use v2 specific label to avoid matching previous deployment-based dispatchers #4104

merged 1 commit into from
Sep 19, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 18, 2024 •
edited
Loading

This ensures that our consumergroup controller only match v2-specific pods and won't try to reconcile pods that belong to the previous deployment.

Seen here #4091 with

failed to schedule consumers: failed to get data plane volume kafka-resources
      in pod knative-eventing/kafka-broker-dispatcher-6b6855d6c5-7nhtw

so the consumergroup controller is trying to reconcile a pod that is not of the statefulset but for the "old" deployment

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/control-plane area/data-plane approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2024
@pierDipi
Copy link
Member Author

/cherry-pick release-1.15

@pierDipi
Copy link
Member Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

/cc @creydr @maschmid

@knative-prow knative-prow bot requested review from creydr and maschmid September 18, 2024 14:22
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 18, 2024
@pierDipi
Copy link
Member Author 

executor.go:189: Sep 18 14:46:04.915 install_head [ERR] The StatefulSet "kafka-source-dispatcher" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

Change to labels to STS is not possible

@pierDipi
Use v2 specific label to avoid matching previous deployment-based dis…
a60ca43 
…patchers

This ensures that our `consumergroup` controller as well as replication
controller only match v2-specific pods and won't try to reconcile
pods that belong to the previous deployment.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the use-v2-specific-label-for-sts-migration branch from 6769f46 to a60ca43 Compare September 18, 2024 15:10
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.56%. Comparing base (8b4b0dd) to head (a60ca43).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ol-plane/pkg/reconciler/testing/objects_channel.go 0.00% 2 Missing ⚠️
...rol-plane/pkg/reconciler/testing/objects_source.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4104   +/-   ##
=======================================
  Coverage   48.55%   48.56%           
=======================================
  Files         244      244           
  Lines       14827    14833    +6     
=======================================
+ Hits         7199     7203    +4     
- Misses       6913     6915    +2     
  Partials      715      715

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/test upgrade-tests

matzew
matzew approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor

matzew commented Sep 19, 2024

Good call, adding this, @pierDipi 👍

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test channel-reconciler-tests-sasl-ssl

@pierDipi
Copy link
Member Author

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot merged commit ec9b65b into knative-extensions:main Sep 19, 2024
34 of 37 checks passed
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #4105

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 19, 2024
Merged
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #4106

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@creydr creydr Awaiting requested review from creydr

@maschmid maschmid Awaiting requested review from maschmid

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/data-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @knative-prow-robot @matzew