Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.17] Remove broken symlinks #4234

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #4231

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added area/control-plane size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2025
@knative-prow knative-prow bot requested review from Cali0707 and matzew January 26, 2025 21:31
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.33%. Comparing base (5c18227) to head (1125025).
Report is 1 commits behind head on release-1.17.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.17    #4234      +/-   ##
================================================
- Coverage         47.34%   47.33%   -0.02%     
================================================
  Files               270      270              
  Lines             19011    19011              
================================================
- Hits               9001     8998       -3     
- Misses             9298     9300       +2     
- Partials            712      713       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsimansk
Copy link
Contributor

/retest

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
Copy link

knative-prow bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@dsimansk
Copy link
Contributor

/override "reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.17"

Copy link

knative-prow bot commented Jan 27, 2025

@dsimansk: Overrode contexts on behalf of dsimansk: reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.17

In response to this:

/override "reconciler-tests-namespaced-broker_eventing-kafka-broker_release-1.17"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Contributor

/override "integration-tests_eventing-kafka-broker_release-1.17"

Copy link

knative-prow bot commented Jan 27, 2025

@dsimansk: Overrode contexts on behalf of dsimansk: integration-tests_eventing-kafka-broker_release-1.17

In response to this:

/override "integration-tests_eventing-kafka-broker_release-1.17"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 9794044 into knative-extensions:release-1.17 Jan 27, 2025
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants