Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate the gopath hacks #454

Merged

Conversation

arghya88
Copy link
Contributor

@arghya88 arghya88 commented Dec 3, 2020

Signed-off-by: Arghya Sadhu arghya88@gmail.com

Fixes #453

Proposed Changes

Use GOPATH hacks to codegen anywhere.

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 3, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 3, 2020
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #454 (a7051d8) into master (a5cc6ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #454   +/-   ##
=========================================
  Coverage     77.14%   77.14%           
  Complexity      260      260           
=========================================
  Files            58       58           
  Lines          1873     1873           
  Branches         82       82           
=========================================
  Hits           1445     1445           
  Misses          320      320           
  Partials        108      108           
Flag Coverage Δ Complexity Δ
java-unittests 77.13% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cc6ee...63488ec. Read the comment docs.

@arghya88 arghya88 changed the title integrate the gopath hacks Integrate the gopath hacks Dec 3, 2020
@slinkydeveloper
Copy link
Contributor

I think the reason why it doesn't work is that you should first update the deps and then update the script

@arghya88
Copy link
Contributor Author

arghya88 commented Dec 3, 2020

@slinkydeveloper once #448 gets merged it will work after rebase

Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arghya88, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@knative-prow-robot knative-prow-robot merged commit 6653d77 into knative-extensions:master Dec 3, 2020
@arghya88 arghya88 deleted the codegen-anywhere branch December 3, 2020 09:26
pierDipi pushed a commit to pierDipi/eventing-kafka-broker that referenced this pull request Feb 27, 2021
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GOPATH hacks to codegen anywhere.
4 participants