-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the gopath hacks #454
Integrate the gopath hacks #454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
=========================================
Coverage 77.14% 77.14%
Complexity 260 260
=========================================
Files 58 58
Lines 1873 1873
Branches 82 82
=========================================
Hits 1445 1445
Misses 320 320
Partials 108 108
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
I think the reason why it doesn't work is that you should first update the deps and then update the script |
@slinkydeveloper once #448 gets merged it will work after rebase |
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
3387896
to
63488ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arghya88, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Arghya Sadhu <arghya88@gmail.com>
Signed-off-by: Arghya Sadhu arghya88@gmail.com
Fixes #453
Proposed Changes
Use GOPATH hacks to codegen anywhere.
Release Note
Docs