Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.22] Fix out of bounds in unordered offset manager #816

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #814

:bug: Fix out of bounds in unordered offset manager

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
@knative-prow-robot knative-prow-robot requested review from a team as code owners April 18, 2021 11:04
@knative-prow-robot knative-prow-robot requested a review from a user April 18, 2021 11:04
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 18, 2021
@google-cla
Copy link

google-cla bot commented Apr 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Apr 18, 2021
@knative-prow-robot knative-prow-robot added area/data-plane size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2021
@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-0.22@05529c6). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.22     #816   +/-   ##
===============================================
  Coverage                ?   76.53%           
  Complexity              ?      439           
===============================================
  Files                   ?       77           
  Lines                   ?     2924           
  Branches                ?      133           
===============================================
  Hits                    ?     2238           
  Misses                  ?      535           
  Partials                ?      151           
Flag Coverage Δ Complexity Δ
java-unittests 80.20% <100.00%> (?) 439.00 <0.00> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...spatcher/consumer/impl/UnorderedOffsetManager.java 100.00% <100.00%> (ø) 13.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05529c6...7f97115. Read the comment docs.

@pierDipi
Copy link
Member

/retest

Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2021
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021
@pierDipi
Copy link
Member

@slinkydeveloper this needs your CLA consent :)

@pierDipi pierDipi added the cla: yes Indicates the PR's author has signed the CLA. label Apr 19, 2021
@google-cla
Copy link

google-cla bot commented Apr 19, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

@google-cla google-cla bot removed the cla: yes Indicates the PR's author has signed the CLA. label Apr 19, 2021
@slinkydeveloper
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Apr 19, 2021
@knative-prow-robot knative-prow-robot merged commit ff8456e into knative-extensions:release-0.22 Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants