-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acks=all #824
acks=all #824
Conversation
Codecov Report
@@ Coverage Diff @@
## main #824 +/- ##
=======================================
Coverage 71.67% 71.67%
=======================================
Files 28 28
Lines 1257 1257
=======================================
Hits 901 901
Misses 277 277
Partials 79 79 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
FYI, Kafka 2.8 has all
as default value
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can you add a release note? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to apply this to kafka sink too in the other cm.
Signed-off-by: Francesco Guardiani francescoguard@gmail.com
Fixes #823
Proposed Changes
Release Note