Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

eventing.knative.dev/scope: namespace does not work with distributed kafka channel #126

Closed
AceHack opened this issue Oct 21, 2020 · 14 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@AceHack
Copy link
Contributor

AceHack commented Oct 21, 2020

Describe the bug
In the previous version eventing.knative.dev/scope: namespace would allow me to connect to different Kafka clusters at least at the namespace level.

Expected behavior
The ability to connect to more than one kafka cluster with knative.

To Reproduce
Add the eventing.knative.dev/scope: namespace to a kafka channel (distributed) and nothing happens.

Knative release version
nightly

Additional context
We don't absolutely need eventing.knative.dev/scope: namespace to work, we just need a way to connect to multiple kafka clusters, like maybe even specifying it at the KafkaChannel level similar to how it is in KafkaSource.

@AceHack AceHack added the kind/bug Categorizes issue or PR as related to a bug. label Oct 21, 2020
@lionelvillard lionelvillard self-assigned this Nov 18, 2020
@lionelvillard
Copy link
Contributor

Related to #157.

@AceHack assuming #157 gets resolved by allowing specifying the config at the KafkaChannel level, are you ok if we deprecate eventing.knative.dev/scope ?

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2021
@AceHack
Copy link
Contributor Author

AceHack commented Feb 18, 2021

Any update?

@lionelvillard
Copy link
Contributor

lionelvillard commented Feb 18, 2021

No progress I'm afraid. We are having discussions in #157 but nothing concrete yet.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 19, 2021
matzew added a commit to matzew/eventing-kafka that referenced this issue Mar 31, 2021
…gistry_updates

Matching OCP Serverless product and clean ups
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 20, 2021
@aliok
Copy link
Member

aliok commented May 24, 2021

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2021
@ssandanshi
Copy link

Any updates on this?

@lionelvillard
Copy link
Contributor

/cc @travis-minke-sap

@travis-minke-sap
Copy link
Contributor

Yeah, I hadn't seen this one in a long while ; ). Definitely something that we should support, and I don't see why the distributed implementation couldn't be made to work similar to consolidated version. My time is going to be focused elsewhere for awhile (#588, #613, etc...) but I've added to my personal internal tracking list of things that Eric and I can look at.

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2021
@travis-minke-sap
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2022
@travis-minke-sap
Copy link
Contributor

/remove-lifecycle stale

@knative-prow-robot knative-prow-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2022
@github-actions github-actions bot closed this as completed May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants