Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

[mt-source] Fix ce-source missing the namespace #361

Merged

Conversation

lionelvillard
Copy link
Contributor

Proposed Changes

  • Propagate source namespace to the st adapter.

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 2, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2021
@lionelvillard lionelvillard changed the title Fix ce-source missing the namespace [mt-source] Fix ce-source missing the namespace Feb 2, 2021
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #361 (b7a42f5) into master (ffd2397) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   75.17%   75.18%           
=======================================
  Files         124      124           
  Lines        4705     4706    +1     
=======================================
+ Hits         3537     3538    +1     
  Misses        948      948           
  Partials      220      220           
Impacted Files Coverage Δ
pkg/source/mtadapter/adapter.go 68.75% <100.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd2397...0f1c919. Read the comment docs.

@steven0711dong
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021
@lionelvillard
Copy link
Contributor Author

/test pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated

@knative-prow-robot knative-prow-robot merged commit af1d613 into knative-extensions:master Feb 3, 2021
matzew added a commit to matzew/eventing-kafka that referenced this pull request Sep 27, 2021
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants