Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Avoid copying msg when extracting the event type #715

Merged

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jun 16, 2021

This is an improvement for #688 .

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 16, 2021
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@knative-prow-robot
Copy link
Contributor

Hi @skonto. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto
Copy link
Contributor Author

skonto commented Jun 16, 2021

/assign @slinkydeveloper

@skonto
Copy link
Contributor Author

skonto commented Jun 16, 2021

lint issue is unrelated and it is fixed in #709

nil,
c.sub.Subscriber,
c.sub.Reply,
c.sub.DeadLetter,
c.sub.RetryConfig,
[]binding.Transformer{&te}...,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why that? you can just use &te

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #715 (3ffe223) into main (19a507e) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
+ Coverage   73.75%   73.78%   +0.03%     
==========================================
  Files         133      133              
  Lines        5821     5818       -3     
==========================================
  Hits         4293     4293              
+ Misses       1310     1307       -3     
  Partials      218      218              
Impacted Files Coverage Δ
...onsolidated/dispatcher/consumer_message_handler.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19a507e...3ffe223. Read the comment docs.

@slinkydeveloper
Copy link
Contributor

Sounds good to me

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto, slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@skonto
Copy link
Contributor Author

skonto commented Jun 16, 2021

/test pull-knative-sandbox-eventing-kafka-upgrade-tests

@knative-prow-robot
Copy link
Contributor

@skonto: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-knative-sandbox-eventing-kafka-upgrade-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto
Copy link
Contributor Author

skonto commented Jun 16, 2021

/retest

@knative-prow-robot
Copy link
Contributor

@skonto: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto
Copy link
Contributor Author

skonto commented Jun 16, 2021

@slinkydeveloper @matzew could you add ok to test?

@knative-prow-robot
Copy link
Contributor

@skonto: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skonto
Copy link
Contributor Author

skonto commented Jun 17, 2021

@slinkydeveloper gentle ping.

@slinkydeveloper
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 17, 2021
@knative-prow-robot knative-prow-robot merged commit 5abaa90 into knative-extensions:main Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants