-
Notifications
You must be signed in to change notification settings - Fork 82
Lock unlock protocol flags #742
Lock unlock protocol flags #742
Conversation
Codecov Report
@@ Coverage Diff @@
## main #742 +/- ##
==========================================
+ Coverage 75.29% 75.64% +0.34%
==========================================
Files 132 140 +8
Lines 5785 6307 +522
==========================================
+ Hits 4356 4771 +415
- Misses 1208 1316 +108
+ Partials 221 220 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eric-sap, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Subtask of #588 to add locks to ConsumerGroupAsyncCommands (dispatcher side)
Proposed Changes
🎁. Added functionality to the managedGroup (resetLockTimer/canUnlock/removeLock) to allow locking and unlocking of a managedGroup via an arbitrary token.
🎁 Changed the stopConsumerGroup and startConsumerGroup functions to call processLock, which understands the fields in the new CommandLock struct of the ConsumerGroupAsyncCommand and will lock/unlock the managedGroup
🧽 Change the Reconfigure function to also obey the managedGroup lock/unlock using an internal CommandLock token
The ResetOffset Controller is still "inactive" and has not been added to any Channels/Sources/etc.
The ResetOffset Controller is still not "complete" and this is a stepping stone in the path to implementing the feature.
Release Note
Release Notes will be provided near the end of the ResetOffset feature development.
Docs
Documentation will be provided near the end of the ResetOffset feature development.