Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #790

Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@knative-prow-robot knative-prow-robot requested review from a team as code owners August 5, 2021 19:00
@knative-prow-robot knative-prow-robot requested review from lionelvillard and julz and removed request for a team August 5, 2021 19:00
@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 5, 2021
@google-cla
Copy link

google-cla bot commented Aug 5, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 5, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2021
@devguyio
Copy link
Contributor

devguyio commented Aug 5, 2021

@googlebot I consent

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Aug 5, 2021
@devguyio
Copy link
Contributor

devguyio commented Aug 5, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2021
@lionelvillard
Copy link
Contributor

/lgtm

@lionelvillard
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, knative-prow-robot, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2021
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-0.23@a5e581a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.23     #792   +/-   ##
===============================================
  Coverage                ?   72.67%           
===============================================
  Files                   ?      140           
  Lines                   ?     5860           
  Branches                ?        0           
===============================================
  Hits                    ?     4259           
  Misses                  ?     1374           
  Partials                ?      227           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5e581a...2cdd7bc. Read the comment docs.

@knative-prow-robot knative-prow-robot merged commit 1fc8e75 into knative-extensions:release-0.23 Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants