-
Notifications
You must be signed in to change notification settings - Fork 82
[release-0.24] removing confusing error message #816
[release-0.24] removing confusing error message #816
Conversation
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## release-0.24 #816 +/- ##
===============================================
Coverage ? 74.66%
===============================================
Files ? 136
Lines ? 6181
Branches ? 0
===============================================
Hits ? 4615
Misses ? 1342
Partials ? 224 Continue to review full report at Codecov.
|
@googlebot I consent. |
/test pull-knative-sandbox-eventing-kafka-unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
@lionelvillard do we want that on 0.25 too?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Co-authored-by: Steven DOng <steven.dong@ibm.com>
* Add clusterrole support for getting namespaces to webhook. (knative-extensions#752) * [release-0.24] [Source] Optimize InitOffsets (knative-extensions#762) * optimize InitOffsets * attempt to fix race Co-authored-by: Lionel Villard <villard@us.ibm.com> * [release-0.24] add missing condition types (knative-extensions#769) * add missing condition types Co-authored-by: Steven DOng <steven.dong@ibm.com> * removing confusing error message (knative-extensions#816) Co-authored-by: Steven DOng <steven.dong@ibm.com> * Regenerating YAMLs, based on changes and we are now using 0.24.3 image promotion Signed-off-by: Matthias Wessendorf <mwessend@redhat.com> Co-authored-by: Travis Minke <travis.minke@sap.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Lionel Villard <villard@us.ibm.com> Co-authored-by: Steven DOng <steven.dong@ibm.com>
This is an automated cherry-pick of #809