Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #809

🐛 Remove confusing error message `Kafka source is not ready`. This error is returned as an event regardless the Kafka source has any real issue or not and users should not see this error message unless it is a legitimate error or it is an error they can fix.

@knative-prow-robot knative-prow-robot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 20, 2021
@google-cla
Copy link

google-cla bot commented Aug 20, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Aug 20, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-0.24@e4c93f8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             release-0.24     #816   +/-   ##
===============================================
  Coverage                ?   74.66%           
===============================================
  Files                   ?      136           
  Lines                   ?     6181           
  Branches                ?        0           
===============================================
  Hits                    ?     4615           
  Misses                  ?     1342           
  Partials                ?      224           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c93f8...f8ce9df. Read the comment docs.

@steven0711dong
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Aug 20, 2021
@lionelvillard
Copy link
Contributor

/test pull-knative-sandbox-eventing-kafka-unit-tests

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@lionelvillard do we want that on 0.25 too?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2021
@knative-prow-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-prow-robot, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2021
@knative-prow-robot knative-prow-robot merged commit 0464cf1 into knative-extensions:release-0.24 Aug 23, 2021
matzew pushed a commit to matzew/eventing-kafka that referenced this pull request Aug 31, 2021
Co-authored-by: Steven DOng <steven.dong@ibm.com>
openshift-merge-robot pushed a commit to openshift-knative/eventing-kafka that referenced this pull request Aug 31, 2021
* Add clusterrole support for getting namespaces to webhook. (knative-extensions#752)

* [release-0.24] [Source] Optimize InitOffsets (knative-extensions#762)

* optimize InitOffsets

* attempt to fix race

Co-authored-by: Lionel Villard <villard@us.ibm.com>

* [release-0.24] add missing condition types (knative-extensions#769)

* add missing condition types

Co-authored-by: Steven DOng <steven.dong@ibm.com>

* removing confusing error message (knative-extensions#816)

Co-authored-by: Steven DOng <steven.dong@ibm.com>

* Regenerating YAMLs, based on changes and we are now using 0.24.3 image promotion

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Co-authored-by: Travis Minke <travis.minke@sap.com>
Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Co-authored-by: Lionel Villard <villard@us.ibm.com>
Co-authored-by: Steven DOng <steven.dong@ibm.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants