Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Make status.address optional in the KafkaChannel CRD #857

Conversation

aliok
Copy link
Member

@aliok aliok commented Sep 6, 2021

Fixes #744

Proposed Changes

Release Note

- 🐛 Fix bug: `status.address` of KafkaChannel is not required anymore, thus conditions are reflected successfully in case of an early stage error

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 6, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2021
@aliok
Copy link
Member Author

aliok commented Sep 6, 2021

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #857 (f5d6c6b) into main (acf06a2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage   74.56%   74.56%           
=======================================
  Files         141      141           
  Lines        6559     6559           
=======================================
  Hits         4891     4891           
  Misses       1428     1428           
  Partials      240      240           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acf06a2...f5d6c6b. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 464ebbd into knative-extensions:main Sep 6, 2021
@aliok aliok deleted the make-status.address-optional branch September 6, 2021 12:47
@pierDipi
Copy link
Member

/cherry-pick release-0.25

@pierDipi
Copy link
Member

/cherry-pick release-0.24

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #868

In response to this:

/cherry-pick release-0.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #869

In response to this:

/cherry-pick release-0.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status.address shouldn't be required
3 participants