This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
[0.24] Move initOffsets functionality to a common package #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
Cherry pick #883 |
Codecov Report
@@ Coverage Diff @@
## release-0.24 #885 +/- ##
===============================================
Coverage ? 74.62%
===============================================
Files ? 136
Lines ? 6184
Branches ? 0
===============================================
Hits ? 4615
Misses ? 1346
Partials ? 223 Continue to review full report at Codecov.
|
|
/lgtm |
aliok
added a commit
to aliok/eventing-kafka
that referenced
this pull request
Oct 4, 2021
…tensions#885) * Move initOffsets functionality to a common package (knative-extensions#884) Co-authored-by: Ali Ok <aliok@redhat.com> * Move initOffsets functionality to a common package (knative-extensions#884) Co-authored-by: Ali Ok <aliok@redhat.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka
that referenced
this pull request
Oct 4, 2021
…tensions#885) (#381) * Move initOffsets functionality to a common package (knative-extensions#884) Co-authored-by: Ali Ok <aliok@redhat.com> * Move initOffsets functionality to a common package (knative-extensions#884) Co-authored-by: Ali Ok <aliok@redhat.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com> Co-authored-by: Knative Prow Robot <knative-prow-robot@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #883
initOffsetsfunction, but do not use it as it is not used in 0.24 codebase