-
Notifications
You must be signed in to change notification settings - Fork 82
[0.25] KafkaChannel to init offsets before dispatcher #913
[0.25] KafkaChannel to init offsets before dispatcher #913
Conversation
[0.24] KafkaChannel to init offsets before dispatcher (knative-extensions#886)
The following is the coverage report on the affected files.
|
@aliok: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## release-0.25 #913 +/- ##
===============================================
Coverage ? 74.06%
===============================================
Files ? 139
Lines ? 6212
Branches ? 0
===============================================
Hits ? 4601
Misses ? 1382
Partials ? 229 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.26 I think there are conflicts but gonna try anyway |
@aliok: #913 failed to apply on top of branch "release-0.26":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ions#913) * Cherry pick 3f2a9d7 [0.24] KafkaChannel to init offsets before dispatcher (knative-extensions#886) * ./hack/update-codegen.sh
…ions#913) * Cherry pick 3f2a9d7 [0.24] KafkaChannel to init offsets before dispatcher (knative-extensions#886) * ./hack/update-codegen.sh
…ions#913) * Cherry pick 3f2a9d7 [0.24] KafkaChannel to init offsets before dispatcher (knative-extensions#886) * ./hack/update-codegen.sh
…ions#913) * Cherry pick 3f2a9d7 [0.24] KafkaChannel to init offsets before dispatcher (knative-extensions#886) * ./hack/update-codegen.sh
* [0.25] KafkaChannel to init offsets before dispatcher (knative-extensions#913) * Cherry pick 3f2a9d7 [0.24] KafkaChannel to init offsets before dispatcher (knative-extensions#886) * ./hack/update-codegen.sh * [0.25] KafkaChannel dispatcher offset checking improvements (knative-extensions#929) * Fix Kafka channel event loss during subscription becoming ready * Make it look like knative-extensions#926
…e-extensions#913)" This reverts commit 813d807.
Manual cherry pick of the same fix in 0.24: #886
Release Note
Docs