Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Moving Placeable type and new Scheduler to eventing core #942

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

aavarghese
Copy link
Contributor

Signed-off-by: aavarghese avarghese@us.ibm.com

Fixes #925

See knative/eventing#5818, #768

Release Note

Moving Placeable type and new HA Scheduler to eventing core

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 15, 2021
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 15, 2021
@aavarghese aavarghese changed the title Moving Placeable type and new Scheduler to eventing core WIP: Moving Placeable type and new Scheduler to eventing core Oct 15, 2021
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #942 (090f9bf) into main (ee67c50) will decrease coverage by 0.62%.
The diff coverage is n/a.

❗ Current head 090f9bf differs from pull request most recent head d781784. Consider uploading reports for the commit d781784 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
- Coverage   75.65%   75.02%   -0.63%     
==========================================
  Files         137      121      -16     
  Lines        6547     5650     -897     
==========================================
- Hits         4953     4239     -714     
+ Misses       1311     1188     -123     
+ Partials      283      223      -60     
Impacted Files Coverage Δ
pkg/apis/sources/v1beta1/kafka_scheduling.go 76.92% <ø> (ø)
pkg/apis/sources/v1beta1/kafka_types.go 66.66% <ø> (ø)
pkg/source/mtadapter/adapter.go 46.61% <ø> (ø)
...or/knative.dev/eventing/pkg/scheduler/placement.go
...labilitynodepriority/availability_node_priority.go
...labilityzonepriority/availability_zone_priority.go
...uler/plugins/core/evenpodspread/even_pod_spread.go
...e/lowestordinalpriority/lowest_ordinal_priority.go
...lugins/core/podfitsresources/pod_fits_resources.go
...priority/remove_with_availability_node_priority.go
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee67c50...d781784. Read the comment docs.

@aavarghese aavarghese force-pushed the scheduler branch 3 times, most recently from e645bad to 09132a3 Compare October 18, 2021 21:12
@aavarghese
Copy link
Contributor Author

WIP because go.mod replace with local vendoring has to be changed after eventing PR is merged.

@aavarghese aavarghese changed the title WIP: Moving Placeable type and new Scheduler to eventing core Moving Placeable type and new Scheduler to eventing core Oct 28, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2021
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/sources/v1beta1/kafka_scheduling.go 81.8% 100.0% 18.2

@aavarghese
Copy link
Contributor Author

/cc @lionelvillard

Signed-off-by: aavarghese <avarghese@us.ibm.com>
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aavarghese, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@knative-prow-robot knative-prow-robot merged commit ebc2166 into knative-extensions:main Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Placeable type to eventing core
4 participants