Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #436

Merged

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Oct 11, 2023

Update dependencies and fix build issues, which came through knative/eventing#7328.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 11, 2023
@creydr
Copy link
Contributor Author

creydr commented Oct 11, 2023

@astelmashenko could you PTAL at this so we get it green before the next release cut?
Thanks a lot in advance

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #436 (c7f05bd) into main (c81accb) will decrease coverage by 0.22%.
The diff coverage is 27.77%.

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
- Coverage   38.97%   38.76%   -0.22%     
==========================================
  Files          29       30       +1     
  Lines        1919     1932      +13     
==========================================
+ Hits          748      749       +1     
- Misses       1125     1137      +12     
  Partials       46       46              
Files Coverage Δ
.../jetstream/dispatcher/typeextractor_transformer.go 0.00% <ø> (ø)
pkg/reconciler/dispatcher/natss/natsschannel.go 73.03% <100.00%> (ø)
pkg/channel/jetstream/dispatcher/dispatcher.go 25.11% <40.00%> (-0.01%) ⬇️
pkg/channel/jetstream/dispatcher/consumer.go 0.00% <0.00%> (ø)

@creydr
Copy link
Contributor Author

creydr commented Oct 11, 2023

/assign @Cali0707

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/override "codecov/patch"

@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

@pierDipi: Overrode contexts on behalf of pierDipi: codecov/patch

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 9499b7b into knative-extensions:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants