Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Update dependencies #437

Closed

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Oct 11, 2023

Fixes some dependency build issues.

For testing

@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #437 (47a63ca) into main (c81accb) will decrease coverage by 0.18%.
The diff coverage is 13.04%.

❗ Current head 47a63ca differs from pull request most recent head a6cb21a. Consider uploading reports for the commit a6cb21a to get more accurate results

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   38.97%   38.80%   -0.18%     
==========================================
  Files          29       29              
  Lines        1919     1925       +6     
==========================================
- Hits          748      747       -1     
- Misses       1125     1132       +7     
  Partials       46       46              
Files Coverage Δ
pkg/channel/jetstream/dispatcher/dispatcher.go 24.55% <42.85%> (-0.56%) ⬇️
pkg/channel/jetstream/dispatcher/consumer.go 0.00% <0.00%> (ø)

@creydr creydr closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant