Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #513

Merged

Conversation

creydr
Copy link
Contributor

@creydr creydr commented Mar 4, 2024

Fixing the dependency bump issues from #511.

Including the following:

  • K8s & KinD bump
  • Dependency bump

@creydr creydr requested a review from Cali0707 March 4, 2024 07:40
@knative-prow knative-prow bot requested review from aliok and pierDipi March 4, 2024 07:40
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.58%. Comparing base (e7bce97) to head (4ad7948).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   45.32%   39.58%   -5.74%     
==========================================
  Files          30       60      +30     
  Lines        1966     3178    +1212     
==========================================
+ Hits          891     1258     +367     
- Misses       1020     1855     +835     
- Partials       55       65      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Contributor Author

creydr commented Mar 4, 2024

/cc @Cali0707 @Leo6Leo

@knative-prow knative-prow bot requested a review from Leo6Leo March 4, 2024 13:26
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link

knative-prow bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor Author

creydr commented Mar 4, 2024

/override "codecov/project"

Copy link

knative-prow bot commented Mar 4, 2024

@creydr: Overrode contexts on behalf of creydr: codecov/project

In response to this:

/override "codecov/project"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit dc7c6ed into knative-extensions:main Mar 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants