grab the latest with test resource cleanups

[vaikas]

Changes

• Grab the latest version of eventing. Also add an import to eventing event-library test image import that was breaking the conformance tests from being built.
• 🐛 Fix a bug in which trigger delivery was not used. Fixes: Support Trigger Delivery spec. #219

/kind

Fixes #

Release Note

Docs

:bug: Fix a bug in which trigger delivery spec was not being used, was always only using Brokers one.

[knative-prow-robot]

@vaikas: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #276 (0d8417f) into main (3f3a1fe) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   60.93%   61.02%   +0.08%     
==========================================
  Files          28       28              
  Lines        1797     1801       +4     
==========================================
+ Hits         1095     1099       +4     
  Misses        616      616              
  Partials       86       86              

Impacted Files	Coverage Δ
pkg/dispatcher/dispatcher.go	81.92% <100.00%> (+0.22%)	⬆️
pkg/reconciler/trigger/trigger.go	55.87% <100.00%> (+0.54%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f3a1fe...0d8417f. Read the comment docs.

[vaikas]

I'll dig into this more tmw, but it's now related to some stuff shuffling around but I can't recall details right at the moment, so will do tmw.

2021/04/21 02:01:55 failed to publish images: importpath "ko://knative.dev/eventing/test/test_images/event-library" is not supported: go/build: importGo knative.dev/eventing/test/test_images/event-library: exit status 1
cannot find package "." in:
	/home/runner/work/eventing-rabbitmq/eventing-rabbitmq/src/knative.dev/eventing-rabbitmq/vendor/knative.dev/eventing/test/test_images/event-library

error attempting to ko publish: exit status 1
--- FAIL: TestBrokerConformance (13.87s)
panic: exit status 1 [recovered]
	panic: exit status 1

[vaikas]

There's still a bug but I'd like to tackle this in a followup so that we can get the stuff building at least:

=== RUN   TestBrokerConformance/Knative_Broker_Specification_-_Control_Plane/Delivery_Spec_-_dlq-test-2/Assert/[Stable/SHOULD]Conformance_When_`TriggerSpec.Delivery`_is_configured,_then_`TriggerSpec.Delivery`_SHOULD_be_used._(Retry)
    event_patterns.go:121: Expected Events brokerdlq;
         Got: knconf.EventPattern{Success:[]bool{}, Interval:[]uint{}}
        Want: knconf.EventPattern{Success:[]bool{}, Interval:[]uint{}}
    event_patterns.go:121: Expected Events t0;
         Got: knconf.EventPattern{Success:[]bool{false, false, false, true}, Interval:[]uint{0x0, 0x0, 0x0, 0xffffffffffffffff}}
        Want: knconf.EventPattern{Success:[]bool{false, false, false, true}, Interval:[]uint{0x0, 0x0, 0x0, 0x0}}
    event_patterns.go:121: Expected Events t0dlq;
         Got: knconf.EventPattern{Success:[]bool{}, Interval:[]uint{}}
        Want: knconf.EventPattern{Success:[]bool{}, Interval:[]uint{}}
    event_patterns.go:121: Expected Events t1;
         Got: knconf.EventPattern{Success:[]bool{false, true}, Interval:[]uint{0x0, 0x0}}
        Want: knconf.EventPattern{Success:[]bool{false}, Interval:[]uint{0x0}}
    event_patterns.go:124: Wanted 1 events, got 2
    event_patterns.go:130: unexpected event acceptance behaviour (-want, +got) =   []bool{
          	false,
        + 	true,
          }

    event_patterns.go:121: Expected Events t1dlq;
         Got: knconf.EventPattern{Success:[]bool{}, Interval:[]uint{}}
        Want: knconf.EventPattern{Success:[]bool{}, Interval:[]uint{}}

[n3wscott]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [n3wscott]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment